275 - Validates documents with signed message and assertion#277
Merged
pitbulk merged 2 commits intoSAML-Toolkits:masterfrom Nov 10, 2015
Merged
275 - Validates documents with signed message and assertion#277pitbulk merged 2 commits intoSAML-Toolkits:masterfrom
pitbulk merged 2 commits intoSAML-Toolkits:masterfrom
Conversation
… verify validity of the response
…nature. As per the SAML specification, a signature can only have one reference node. (5.4.2 References)
Contributor
Author
|
@pitbulk Do you have any notes on this? |
Collaborator
|
@levelboy Sorry, I had no time to review it yet. |
Collaborator
|
Hi @levelboy, Thanks you very much for the PR, it seems that fixs the bug introduced at 1.1.0 I read again the SAML standard and you are right, SAML expects only 1 reference So we will apply your patch. P.S We followed xmlsec lib steps that loop over all the references, but is true we don't need to do that on SAML: |
Contributor
Author
|
Great, thanks @pitbulk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Migrations
NO
Description
see #275
The modification is that when we check the signature of the response, we only check the first Reference object for that signature. According to the SAML standard, a signature node can only have one Reference node within.
Related PRs
Problem seems to be introduced here: 275512a
Todos
Deploy Notes
No deploy notes.
Steps to Test or Reproduce
First commit adds relevant response document and failing test. Run
rake testto see it failing.